abhishekagarwal87 commented on code in PR #15502:
URL: https://github.com/apache/druid/pull/15502#discussion_r1418343515
##########
extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/hll/HllSketchAggregatorFactory.java:
##########
@@ -172,8 +172,10 @@ public void reset(final ColumnValueSelector selector)
@Override
public void fold(final ColumnValueSelector selector)
{
- final HllSketchHolder sketch = (HllSketchHolder) selector.getObject();
- union.update(sketch.getSketch());
+ final HllSketchHolder sketchHolder = (HllSketchHolder)
selector.getObject();
+ if (sketchHolder != null) {
Review Comment:
can you add this note because we don't check for nulls in most of agg
factories.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
