zachjsh commented on code in PR #15469:
URL: https://github.com/apache/druid/pull/15469#discussion_r1418478640
##########
server/src/main/java/org/apache/druid/catalog/model/ColumnSpec.java:
##########
@@ -49,14 +48,10 @@ public class ColumnSpec
private final String name;
/**
- * The data type of the column expressed as a supported SQL type. The data
type here must
- * directly match a Druid storage type. So, {@code BIGINT} for {code long},
say.
- * This usage does not support Druid's usual "fudging": one cannot use
{@code INTEGER}
- * to mean {@code long}. The type will likely encode complex and aggregation
types
- * in the future, though that is not yet supported. The set of valid
mappings is
- * defined in the {@link Columns} class.
+ * The data type of the column expressed as a supported Druid type. The data
type here must
+ * directly match a Druid storage type.
*/
- private final String sqlType;
+ private final String dataType;
Review Comment:
What is the reasoning behind changing from sql type to druid type here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
