abhishekrb19 opened a new pull request, #15507: URL: https://github.com/apache/druid/pull/15507
This PR bumps up the max heap memory for unit tests from 1.5 GB to 2 GB. ### Why? While looking into https://github.com/apache/druid/pull/15495, I noticed that the MSQ Controller tests were consistently failing only in jdk 17 (e.g., [job-19381423068](https://github.com/apache/druid/actions/runs/7117839945/job/19381423068) and [job-19393777007]( https://github.com/apache/druid/actions/runs/7122105769/job/19393777007). This is partly precipitated by the fact that jdk 17 tests have jfr profiling enabled. Analyzing the heap dump from [job-19393777007](https://github.com/apache/druid/actions/runs/7122105769/job/19393777007), it seems that the [ClusterByStatisticsCollectorImplTest.java](https://github.com/apache/druid/blob/master/extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/statistics/ClusterByStatisticsCollectorImplTest.java#L100) is probably taking up too much memory with 1M rows and the jfr profiler contributes to about 6% of the strong reachable objects. Unit tests and CI succeeded after the heap size increase: https://github.com/apache/druid/pull/15495/commits/c8f92d79bedaadebf7179f6b42b4308b6fb123d1 <!-- Thanks for trying to help us make Apache Druid be the best it can be! Please fill out as much of the following information as is possible (where relevant, and remove it when irrelevant) to help make the intention and scope of this PR clear in order to ease review. --> <!-- Please read the doc for contribution (https://github.com/apache/druid/blob/master/CONTRIBUTING.md) before making this PR. Also, once you open a PR, please _avoid using force pushes and rebasing_ since these make it difficult for reviewers to see what you've changed in response to their reviews. See [the 'If your pull request shows conflicts with master' section](https://github.com/apache/druid/blob/master/CONTRIBUTING.md#if-your-pull-request-shows-conflicts-with-master) for more details. --> <!-- Replace XXXX with the id of the issue fixed in this PR. Remove this section if there is no corresponding issue. Don't reference the issue in the title of this pull-request. --> <!-- If you are a committer, follow the PR action item checklist for committers: https://github.com/apache/druid/blob/master/dev/committer-instructions.md#pr-and-issue-action-item-checklist-for-committers. --> This PR has: - [x] been self-reviewed. - [x] added documentation for new or modified features or behaviors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
