vtlim commented on code in PR #15486:
URL: https://github.com/apache/druid/pull/15486#discussion_r1419521740
##########
website/redirects.js:
##########
@@ -310,11 +310,14 @@ const Redirects=[
"from": "/docs/latest/operations/api-reference.html",
"to": "/docs/latest/api-reference/"
},
+ {
+ "from": "/docs/latest/design/processes.html",
Review Comment:
Do you also need to remove
[process.md](https://github.com/ektravel/druid/blob/sidebar-add-services/docs/design/processes.md)
as well?
##########
docs/design/storage.md:
##########
@@ -0,0 +1,142 @@
+---
+id: storage
+title: "Storage components"
Review Comment:
This doc seems more than just storage components. Maybe "Storage" or
"Storage overview"?
##########
docs/design/storage.md:
##########
@@ -0,0 +1,142 @@
+---
+id: storage
+title: "Storage components"
+---
+
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing,
+ ~ software distributed under the License is distributed on an
+ ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~ KIND, either express or implied. See the License for the
+ ~ specific language governing permissions and limitations
+ ~ under the License.
+ -->
+
+This topic describes the components integral to data storage in Apache Druid.
+
+## Datasources and segments
Review Comment:
This intro is short and seems slightly differently focused than what the
topic is about. What about removing the "Datasources and segments" subheading
and having the intro start from "Druid stores data in datasources..."
I think this would also be more direct, since a
[datasource](https://druid.apache.org/docs/latest/querying/datasource/) is not
a storage component.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
