clintropolis commented on code in PR #15512: URL: https://github.com/apache/druid/pull/15512#discussion_r1419651552
########## docs/querying/timeseriesquery.md: ########## @@ -126,9 +126,10 @@ The grand totals row will appear as the last row in the result array, and will h row even if the query is run in "descending" mode. Post-aggregations in the grand totals row will be computed based upon the grand total aggregations. -## Zero-filling +## NULL filling Review Comment: I wonder if we should call this "Empty filling" or "Empty bucket filling" or something similar? It doesn't actually always fill with zeros or nulls depending on the mode, rather it fills with the default values of the aggregator functions. Since they aggregate no rows, only the default value is there. https://github.com/apache/druid/blob/master/docs/querying/sql-aggregations.md has the default values of the aggregators. ########## docs/querying/timeseriesquery.md: ########## @@ -126,9 +126,10 @@ The grand totals row will appear as the last row in the result array, and will h row even if the query is run in "descending" mode. Post-aggregations in the grand totals row will be computed based upon the grand total aggregations. -## Zero-filling +## NULL filling -Timeseries queries normally fill empty interior time buckets with zeroes. For example, if you issue a "day" granularity +By default timeseries queries fill empty interior time buckets with NULL. Review Comment: same comment about default aggregator value(s), and in other places too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
