clintropolis opened a new pull request, #15532: URL: https://github.com/apache/druid/pull/15532
### Description Fixes a regression from #15505 for nested fields which contain only empty arrays. That PR was a bit focused on top level array columns but it introduced an error for nested paths, which always write the type bytes. The changes in #15505 would result in writing an empty type byte for the field, so now steps are taken to ensure that will never be the case, and if we get to the point of writing out a type byte, it will be populated with an array type if the empty array flag is set. The added test would fail since the empty type byte would not be convertible to an `ExpressionType`, resulting in a failure of the 'fromColumnTypeStrict' method. <hr> This PR has: - [ ] been self-reviewed. - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [ ] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
