FrankChen021 commented on PR #15530: URL: https://github.com/apache/druid/pull/15530#issuecomment-1849224169
The original issue is not re-produced on the master branch, but got a lots of checkstyle problems when running the command ``` mvn package install -DskipTests -Pdist -Prat ``` The checkstyle problems are all for files in the generated-source directory of `druid-sql` module. I think the change in this PR makes sense. But I would like to suggest **using global match to exclude all checks for the generated source** files like the following instead of adding supression rules one by one to the supression file. ``` <suppress files="[\\/]target[\\/]generated-test-sources[\\/]" checks=".*"/> <suppress files="[\\/]target[\\/]generated-sources[\\/]" checks=".*"/> ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
