KeerthanaSrikanth commented on code in PR #15522:
URL: https://github.com/apache/druid/pull/15522#discussion_r1423778606


##########
owasp-dependency-check-suppressions.xml:
##########
@@ -330,14 +330,6 @@
     <cve>CVE-2022-25647</cve>
   </suppress>
 
-  <suppress>
-    <!-- pac4j-core-3.8.3 -->
-    <notes><![CDATA[
-   file name: pac4j-core-3.8.3.jar

Review Comment:
   [CVE-2021-44878](https://github.com/advisories/GHSA-xhw6-hjc9-679m) and the 
[pac4j release notes](https://www.pac4j.org/docs/release-notes.html) both 
indicate that `4.5.5` is a fixed version. But the security scan still flags 
this CVE. 



##########
extensions-core/druid-pac4j/src/test/java/org/apache/druid/security/pac4j/Pac4jSessionStoreTest.java:
##########
@@ -54,7 +60,73 @@ public void testSetAndGet()
     WebContext webContext2 = EasyMock.mock(WebContext.class);
     
EasyMock.expect(webContext2.getRequestCookies()).andReturn(Collections.singletonList(cookie));
     EasyMock.replay(webContext2);
+    Assert.assertEquals("value", 
Objects.requireNonNull(sessionStore.get(webContext2, "key")).orElse(null));
+  }
+
+  @Test
+  public void testSetAndGetClearUserProfile()

Review Comment:
   These two tests were added to improve code coverage



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to