adarshsanjeev commented on code in PR #15516: URL: https://github.com/apache/druid/pull/15516#discussion_r1424825843
########## docs/development/extensions-core/datasketches-hll.md: ########## @@ -51,6 +51,14 @@ For additional sketch types supported in Druid, see [DataSketches extension](dat The default `lgK` value has proven to be sufficient for most use cases; expect only very negligible improvements in accuracy with `lgK` values over `16` in normal circumstances. ::: +### Runtime properties + +The following runtime properties apply: + +|Property| Description| Default | +|--------|------------|------| +|`druid.sketch.config.hllMaxLgK`| The maximum possible value of lgK that HLL sketches can be created with. Useful to limit the maximum lgK in sketches, to avoid the significant usage of resources used by sketches at higher values of lgK. An exception will be thrown if a query configures a lgK value higher than this. This property needs to be set on the broker and middle-manager/indexer. | 20 | Review Comment: The lgK can be specified during query time as well, wouldn't it need to be limited to avoid running into similar issues? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
