kgyrtkirk commented on code in PR #15554: URL: https://github.com/apache/druid/pull/15554#discussion_r1426914251
########## sql/src/main/java/org/apache/druid/sql/calcite/expression/builtin/RoundOperatorConversion.java: ########## @@ -32,22 +30,18 @@ public class RoundOperatorConversion implements SqlOperatorConversion Review Comment: I wonder if there is any reason to keep this class? would be using ``` new DirectOperatorConversion(SqlStdOperatorTable.ROUND, Function.Round.NAME) ``` in `DruidOperatorTable` instead of `new RoundOperatorConversion()` has any drawbacks ? note: it seems like `UnaryFunctionOperatorConversion` doesn't have `toDruidExpressionWithPostAggOperands` implemented - is that a problem? or we specifically don't want to allow that for `isnull` and `notnull` ? I now wonder why to keep the `UnaryFunctionOperatorConversion` class around as well... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
