kfaraz commented on code in PR #15589:
URL: https://github.com/apache/druid/pull/15589#discussion_r1429449439
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/actions/SegmentAllocateAction.java:
##########
@@ -272,8 +273,12 @@ private SegmentIdWithShardSpec
tryAllocateFirstSegment(TaskActionToolbox toolbox
{
// No existing segments for this row, but there might still be nearby ones
that conflict with our preferred
// segment granularity. Try that first, and then progressively smaller
ones if it fails.
+ // Consider trying with WEEK granularity only if the preferred granularity
is WEEK
final List<Interval> tryIntervals =
Granularity.granularitiesFinerThan(preferredSegmentGranularity)
Review Comment:
+1, add a new method named `Granularity.nonWeekgranularitiesFinerThan()` or
something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
