gianm commented on PR #15420: URL: https://github.com/apache/druid/pull/15420#issuecomment-1878164205
@LakshSingla TY for the patch! Would you mind leaving an explanation in a comment here about how the fix works? Like: - what code is responsible for figuring out how many merge buffers to allocate - what code is responsible for actually allocating them - where they get stored once allocated from the server-wide pool - how they get released back to the server-wide pool It'll aid in reviewing, and aid anyone that comes back later to try to read about the logic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
