abhishekagarwal87 commented on code in PR #15523:
URL: https://github.com/apache/druid/pull/15523#discussion_r1444678741
##########
extensions-core/azure-extensions/src/test/java/org/apache/druid/storage/azure/AzureStorageDruidModuleTest.java:
##########
@@ -259,6 +259,26 @@ public void testAllCredentialsUnset()
);
}
+ @Test
+ public void testGetAzureUtilsWithDefaultProperties()
Review Comment:
```suggestion
public void testGetBlobStorageEndpointWithDefaultProperties()
```
##########
extensions-core/azure-extensions/src/test/java/org/apache/druid/storage/azure/AzureUtilsTest.java:
##########
@@ -206,4 +207,18 @@ public void
test_azureRetry_RunTimeExceptionWrappedInRunTimeException_returnsFal
boolean retry =
AzureUtils.AZURE_RETRY.apply(RUNTIME_EXCEPTION_WRAPPED_IN_RUNTIME_EXCEPTON);
Assert.assertFalse(retry);
}
+
+ @Test
+ public void testGetAzureUtilsWithDefaultProperties()
Review Comment:
```suggestion
public void testRemoveAzurePathPrefixDefaultEndpoint()
```
##########
extensions-core/azure-extensions/src/test/java/org/apache/druid/storage/azure/AzureStorageDruidModuleTest.java:
##########
@@ -259,6 +259,26 @@ public void testAllCredentialsUnset()
);
}
+ @Test
+ public void testGetAzureUtilsWithDefaultProperties()
+ {
+ Properties properties = initializePropertes();
+ AzureAccountConfig config =
makeInjectorWithProperties(properties).getInstance(AzureAccountConfig.class);
+ Assert.assertEquals(config.getEndpointSuffix(),
AzureUtils.DEFAULT_AZURE_ENDPOINT_SUFFIX);
+ Assert.assertEquals(config.getBlobStorageEndpoint(),
AzureUtils.AZURE_STORAGE_HOST_ADDRESS);
+ }
+
+ @Test
+ public void testGetAzureUtilsWithDefaultCustomBlobPath()
Review Comment:
```suggestion
public void testGetBlobStorageEndpointWithCustomBlobPath()
```
##########
extensions-core/azure-extensions/src/test/java/org/apache/druid/storage/azure/AzureUtilsTest.java:
##########
@@ -206,4 +207,18 @@ public void
test_azureRetry_RunTimeExceptionWrappedInRunTimeException_returnsFal
boolean retry =
AzureUtils.AZURE_RETRY.apply(RUNTIME_EXCEPTION_WRAPPED_IN_RUNTIME_EXCEPTON);
Assert.assertFalse(retry);
}
+
+ @Test
+ public void testGetAzureUtilsWithDefaultProperties()
+ {
+ String outputBlob =
AzureUtils.maybeRemoveAzurePathPrefix("blob.core.windows.net/container/blob",
"blob.core.windows.net");
+ Assert.assertEquals("container/blob", outputBlob);
+ }
+
+ @Test
+ public void testGetAzureUtilsWithDefaultCustomBlobPath()
Review Comment:
```suggestion
public void testRemoveAzurePathPrefixCustomEndpoint()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
