gianm commented on code in PR #15633:
URL: https://github.com/apache/druid/pull/15633#discussion_r1445332356
##########
processing/src/main/java/org/apache/druid/segment/VirtualColumn.java:
##########
@@ -299,13 +300,16 @@
/**
* Get the {@link ColumnIndexSupplier} for the specified virtual column,
with the assistance of a
- * {@link ColumnSelector} to allow reading things from segments. If the
virtual column has no indexes, this method
- * will return null, or may also return a non-null supplier whose methods
may return null values - having a supplier
- * is no guarantee that the column has indexes.
+ * {@link ColumnIndexSelector} to allow reading things from segments. If the
virtual column has no indexes, this
+ * method will return null, or may also return a non-null supplier whose
methods may return null values - having a
+ * supplier is no guarantee that the column has indexes.
*/
@SuppressWarnings("unused")
@Nullable
- default ColumnIndexSupplier getIndexSupplier(String columnName,
ColumnSelector columnSelector)
+ default ColumnIndexSupplier getIndexSupplier(
+ String columnName,
Review Comment:
There hasn't been much use that comes up for dot notation other than the
original `map` virtual column. The JSON stuff could have used it, but we ended
up going the more standard `JSON_VALUE` way instead. IMO it's fine to say
simplify this and say that dot-notation virtual columns don't get to supply
indexes. I'm OK either way though really.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
