clintropolis opened a new pull request, #15644:
URL: https://github.com/apache/druid/pull/15644

   ### Description
   Fixes an issue with `ExpressionVirtualColumn` index supplier not correctly 
handling the case where MVDs are used as arrays in the expression (e.g. 
MV_OFFSET or any of the other mvd array functions). Added missing 
`ExpressionSelectors.canMapOverDictionary` check which is similar to what is 
used by `ExpressionFilter` to handle the same cases. 
   
   This PR has:
   
   - [x] been self-reviewed.
   - [x] added comments explaining the "why" and the intent of the code 
wherever would not be obvious for an unfamiliar reader.
   - [x] added unit tests or modified existing tests to cover new code paths, 
ensuring the threshold for [code 
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
 is met.
   - [x] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to