LakshSingla commented on code in PR #15474:
URL: https://github.com/apache/druid/pull/15474#discussion_r1445641573
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/querykit/groupby/GroupByPostShuffleFrameProcessor.java:
##########
@@ -306,17 +321,23 @@ private static HavingSpec cloneHavingSpec(final
GroupByQuery query)
* this processor. Kept in sync with the signature generated by {@link
GroupByQueryKit}.
*/
private static VirtualColumns makeVirtualColumnsForFrameWriter(
+ @Nullable final VirtualColumn partitionBoostVirtualColumn,
final ObjectMapper jsonMapper,
final GroupByQuery query
)
{
+ List<VirtualColumn> virtualColumns = new ArrayList<>();
Review Comment:
I removed the conditionals all together, therefore the code is now
straightforward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
