abhishekagarwal87 commented on code in PR #15656:
URL: https://github.com/apache/druid/pull/15656#discussion_r1447298298
##########
processing/src/main/java/org/apache/druid/data/input/impl/FileEntity.java:
##########
@@ -51,7 +51,9 @@ public File file()
@Override
public void close()
{
- // do nothing
+ if (!file.delete()) {
+ LOG.warn("Failed to remove file[%s]", file.getAbsolutePath());
+ }
Review Comment:
Druid didn't create this file. So it shouldn't delete it either. The
temporary file that is created in the default implementation does get deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
