clintropolis opened a new pull request, #15665:
URL: https://github.com/apache/druid/pull/15665
### Description
This PR cleans up some stuff after the removal of group by v1 in #14866 so
that stuff is a bit easier to follow. The biggest material change is that all
common code of `GroupByQueryEngineV2` that is used by both non-vectorized and
vectorized engines has been moved into `GroupingEngine`, including the
`process` method which chooses which of non-vectorized and vectorized
processing to use, and has been inlined into the `process` method of
`GroupingEngine`.
Other changes:
* `GroupByQueryEngineV2` has been renamed to `GroupByQueryEngine`, and now
is totally focused on non-vectorized processing (since shared stuff has been
moved into `GroupingEngine`
* `GroupByMergingQueryRunnerV2` has been renamed to
`GroupByMergingQueryRunner`
* `GroupByBinaryFnV2` has been renamed to `GroupByResultMergeFn`
<hr>
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
