ankit0811 commented on code in PR #15607:
URL: https://github.com/apache/druid/pull/15607#discussion_r1449133858
##########
sql/src/main/java/org/apache/druid/sql/calcite/aggregation/builtin/EarliestLatestAnySqlAggregator.java:
##########
@@ -112,18 +112,6 @@ AggregatorFactory createAggregatorFactory(
return new DoubleFirstAggregatorFactory(name, fieldName,
timeColumn);
case STRING:
case COMPLEX:
- if (type.getComplexTypeName() != null) {
- switch (type.getComplexTypeName()) {
- case SerializablePairLongLongComplexMetricSerde.TYPE_NAME:
- return new LongFirstAggregatorFactory(name, fieldName,
timeColumn);
- case SerializablePairLongFloatComplexMetricSerde.TYPE_NAME:
- return new FloatFirstAggregatorFactory(name, fieldName,
timeColumn);
- case SerializablePairLongDoubleComplexMetricSerde.TYPE_NAME:
- return new DoubleFirstAggregatorFactory(name, fieldName,
timeColumn);
- default:
- return new StringFirstAggregatorFactory(name, fieldName,
timeColumn, maxStringBytes);
- }
- }
Review Comment:
this was a no-op post return type change that was suggested. Since we were
returning the scalar type, it would eventually resolve to the right last/first
AggregatorFactory
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
