YongGang commented on PR #15445: URL: https://github.com/apache/druid/pull/15445#issuecomment-1887778225
> I think the code changes look good. > > To prove this works, a module test would be helpful here to validate that the KubernetesAndWorkerTaskRunnerFactory can be injected without any dependencies for the remoteTaskRunnerFactory being provided. > > After the test, +1 from me Added module test to verify the binding works -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
