clintropolis commented on code in PR #15626:
URL: https://github.com/apache/druid/pull/15626#discussion_r1448850074
##########
benchmarks/src/test/java/org/apache/druid/benchmark/query/SqlBenchmark.java:
##########
@@ -461,66 +479,112 @@ public class SqlBenchmark
public void setup()
{
final GeneratorSchemaInfo schemaInfo =
GeneratorBasicSchemas.SCHEMA_MAP.get("basic");
-
- final DataSegment dataSegment = DataSegment.builder()
- .dataSource("foo")
-
.interval(schemaInfo.getDataInterval())
- .version("1")
- .shardSpec(new
LinearShardSpec(0))
- .size(0)
- .build();
-
- final PlannerConfig plannerConfig = new PlannerConfig();
-
+ final DataSegment dataSegment = schemaInfo.makeSegmentDescriptor("foo");
Review Comment:
:+1:
##########
sql/src/main/java/org/apache/druid/sql/calcite/planner/DruidOperatorTable.java:
##########
@@ -268,8 +268,8 @@ public class DruidOperatorTable implements SqlOperatorTable
.add(new MultiValueStringOperatorConversions.Append())
.add(new MultiValueStringOperatorConversions.Prepend())
.add(new MultiValueStringOperatorConversions.Concat())
- .add(new MultiValueStringOperatorConversions.Contains())
- .add(new MultiValueStringOperatorConversions.Overlap())
+ .add(MultiValueStringOperatorConversions.CONTAINS)
Review Comment:
it does seem kind of handy to be able to check for specific operators in
places, i wonder should we do this for all of them? (not in this PR obviously,
just thinking out loud). I guess the complexity is a lot of them are only
defined inline here and don't have a nice place to live like some of the
operator conversions that are grouped in the same place like these multi-value
string operators are..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
