maytasm commented on PR #15340: URL: https://github.com/apache/druid/pull/15340#issuecomment-1889750276
@suneet-s @vtlim @adarshsanjeev Are we all good on merging this change in? I'll merge this change in at the end of the day if no one has any objection. This change is contained in it's own extension (and is a contrib extension) so should be safe to merge. Including my approval, we have 3 +1s from committers and total reviews from 4 committers. I think this extension does serve a specific use case and does it well. This could be beneficial to some people and hence I do see a value in getting this merge in so that Druid users can easily use/try it out. By getting this extension merge in, we can also keep this extension up-to-dated with any new Druid changes, encourage improvements to this extension from the community (such as adding vectorization, etc) and get feedback about the extension. Note that at Netflix, we have been running this extension at scale in production for a few years so it is also battle tested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
