abhishekrb19 commented on code in PR #15679:
URL: https://github.com/apache/druid/pull/15679#discussion_r1451768471


##########
integration-tests/src/test/java/org/apache/druid/tests/security/ITBasicAuthConfigurationTest.java:
##########
@@ -77,6 +77,20 @@ public void test_druid99User_hasNodeAccess()
     checkNodeAccess(druid99);
   }
 
+  @Override
+  protected void setupHttpClientsAndUsers() throws Exception
+  {
+    super.setupHttpClientsAndUsers();
+
+    // Add a delay to allow propagation of credentials to all services
+    try {
+      Thread.sleep(5000);

Review Comment:
   Do we know what changed here recently in auth land that this sleep is 
required? At any rate, I wonder if we could poll `/status` and/or issue a 
similar API call to verify things are setup instead of a static sleep.



##########
integration-tests/src/test/java/org/apache/druid/tests/security/ITBasicAuthConfigurationTest.java:
##########
@@ -77,6 +77,20 @@ public void test_druid99User_hasNodeAccess()
     checkNodeAccess(druid99);
   }
 
+  @Override
+  protected void setupHttpClientsAndUsers() throws Exception
+  {
+    super.setupHttpClientsAndUsers();
+
+    // Add a delay to allow propagation of credentials to all services
+    try {
+      Thread.sleep(5000);
+    }
+    catch (Throwable t) {

Review Comment:
   ```suggestion
       catch (InterruptedException e) {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to