kfaraz opened a new pull request, #15705:
URL: https://github.com/apache/druid/pull/15705
[WIP: Do Not Merge]
### Description
This is a follow up to #14695 . While the first PR addressed
`DruidProcessingConfig`, this PR tries to get rid of skife configs from
`DruidCoordinatorConfig`.
### Changes
- Add the following new config classes. More details about the bound paths
in the next section.
- `CoordinatorKillConfigs`
- `CoordinatorRunConfig`
- `CoordinatorPeriodConfig`
- `MetadataCleanupConfig`
- `DruidCoordinatorConfig` is not directly bound to any config path anymore.
Instead, all the bound configs get injected into it.
-
### Bound config paths
### Release note
TODO
<hr>
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
