YongGang commented on code in PR #15695:
URL: https://github.com/apache/druid/pull/15695#discussion_r1456280436
##########
extensions-core/azure-extensions/src/main/java/org/apache/druid/storage/azure/AzureTaskLogs.java:
##########
@@ -99,6 +99,20 @@ private void pushTaskFile(final File logFile, String taskKey)
}
}
+ @Override
+ public void pushTaskPayload(String taskid, File taskPayloadFile)
+ {
+ final String taskKey = getTaskPayloadKey(taskid);
+ log.info("Pushing task payload [%s] to location [%s]", taskPayloadFile,
taskKey);
+ pushTaskFile(taskPayloadFile, taskKey);
+ }
+
+ @Override
+ public Optional<InputStream> streamTaskPayload(String taskid) throws
IOException
+ {
+ return streamTaskFile(taskid, 0, getTaskPayloadKey(taskid));
Review Comment:
Seems the `taskid` is not used in `streamTaskFile` method thus can be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
