ektravel commented on code in PR #15591:
URL: https://github.com/apache/druid/pull/15591#discussion_r1456549098


##########
docs/api-reference/supervisor-api.md:
##########
@@ -2046,9 +2215,22 @@ Host: http://ROUTER_IP:ROUTER_PORT
 
 Creates a new supervisor or updates an existing one for the same datasource 
with a new schema and configuration.
 
-You can define a supervisor spec for [Apache 
Kafka](../development/extensions-core/kafka-ingestion.md#define-a-supervisor-spec)
 or [Amazon 
Kinesis](../development/extensions-core/kinesis-ingestion.md#supervisor-spec) 
streaming ingestion methods. Once created, the supervisor persists in the 
metadata database.
+You can define a supervisor spec for [Apache 
Kafka](../development/extensions-core/kinesis-ingestion.md#supervisor-spec) or 
[Amazon 
Kinesis](../development/extensions-core/kinesis-ingestion.md#supervisor-spec) 
streaming ingestion methods. Once created, the supervisor persists in the 
metadata database.
+
+The following table lists the properties of a supervisor spec:
+
+|Property|Type|Description|Required|
+|--------|----|-----------|--------|
+|`type`|String|The supervisor type. Choose from `kafka` or `kinesis`.|Yes|
+|`spec`|Object|The container object for the supervisor configuration.|Yes|
+|`ioConfig`|Object|The I/O configuration object to define the connection and 
I/O-related settings for the supervisor and indexing task.|Yes|

Review Comment:
   We'd have to add two links: one for 
[kafka](https://github.com/apache/druid/pull/15591/files#diff-99c137e119430dfc8c147ed6f8e4c0e9cf8d0f90fe431f11e90012737971775eR132)
 and another one for 
[kinesis](https://github.com/apache/druid/pull/15591/files#diff-2acfb7159631050ba2c8049367dfe36fbcb544162bb502d44e7e15ddd8933dacR130).
 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to