clintropolis commented on PR #15694: URL: https://github.com/apache/druid/pull/15694#issuecomment-1897618692
>Personally, I like the Expr#singleThreaded approach, since it may be useful in the future for other purposes I think what I don't like is that I don't really see why someone would ever call `eval` on a non-single threaded expression.. afaik it seems like all callers of eval are always single threads, but the problem is the `Expr` itself which the eval comes from isn't. I guess we don't want to have to parse into `Expr` for each separate thread since the expression itself doesn't change, but .. something feels slightly off here, I just can't quite determine why. LIke with `GenericIndexed` there is a legitimate reason to use multi-threaded thing, anything that needs to read stuff from the shared dictionary, but `Expr` I just can't really see the case. Should `Expr` just build something similar to how we do for vector processing (`asVectorProcessor`, maybe we have `asProcessor`) that does the actual eval so that the processor is always expected to be single threaded? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
