zachjsh commented on code in PR #15630:
URL: https://github.com/apache/druid/pull/15630#discussion_r1464072526
##########
extensions-core/azure-extensions/src/main/java/org/apache/druid/storage/azure/output/AzureStorageConnector.java:
##########
@@ -50,7 +51,7 @@ public class AzureStorageConnector extends
ChunkingStorageConnector<AzureInputRa
public AzureStorageConnector(
final AzureOutputConfig config,
- final AzureStorage azureStorage
+ @Global final AzureStorage azureStorage
Review Comment:
I dont think this annotation does anything without the constructor being
annotated with `@inject`. Think you need to inject the global into
`AzureStorageConnectorProvider`. But also is this connector only ever used for
segment / logs / task storage? The global storage is always the correct thing
to use in this case?
##########
extensions-core/azure-extensions/src/main/java/org/apache/druid/storage/azure/output/AzureStorageConnector.java:
##########
@@ -50,7 +51,7 @@ public class AzureStorageConnector extends
ChunkingStorageConnector<AzureInputRa
public AzureStorageConnector(
final AzureOutputConfig config,
- final AzureStorage azureStorage
+ @Global final AzureStorage azureStorage
Review Comment:
I dont think this annotation does anything without the constructor being
annotated with `@inject`. Think you need to inject the global into
`AzureStorageConnectorProvider`. But also is this connector only ever used for
segment / logs / task storage? The global storage is always the correct thing
to use in this case? Just making sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
