kgyrtkirk commented on code in PR #15766:
URL: https://github.com/apache/druid/pull/15766#discussion_r1470612690
##########
sql/src/main/java/org/apache/druid/sql/calcite/filtration/CombineAndSimplifyBounds.java:
##########
@@ -270,6 +269,18 @@ private static DimFilter doSimplify(final List<DimFilter>
children, boolean disj
childrenToAdd.add(Ranges.toFilter(rangeRefKey, range));
}
}
+ } else {
+ if (disjunction && rangeSet.asRanges().size() == 2) {
Review Comment:
originally I just wanted to pass all the tests :D
...it doesn't handle that - but it does handle cases better when at the same
level there are candidates for `BETWEEN` and for `NOT BETWEEN` as well
I'll think about it a bit and update the patch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
