kgyrtkirk commented on code in PR #15735:
URL: https://github.com/apache/druid/pull/15735#discussion_r1470833552
##########
processing/src/main/java/org/apache/druid/data/input/Rows.java:
##########
@@ -77,6 +79,8 @@ public static List<String> objectToStrings(final Object
inputValue)
} else if (inputValue instanceof byte[]) {
// convert byte[] to base64 encoded string
return Collections.singletonList(StringUtils.encodeBase64String((byte[])
inputValue));
+ } else if (inputValue instanceof ByteBuffer) {
+ return Collections.singletonList(StringUtils.fromUtf8(((ByteBuffer)
inputValue).array()));
Review Comment:
indeed - the method is called `objectsToStrings`; I've convinced myself that
if the expectation is to get a `string` for any `bytea` value its better to
show it as something which could not be misrepresented...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
