adarshsanjeev commented on code in PR #15689: URL: https://github.com/apache/druid/pull/15689#discussion_r1471054825
########## sql/src/main/java/org/apache/druid/sql/destination/ExportDestination.java: ########## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.sql.destination; + +import com.fasterxml.jackson.annotation.JsonIgnore; +import com.fasterxml.jackson.annotation.JsonProperty; +import com.fasterxml.jackson.annotation.JsonTypeName; + +import java.util.Map; +import java.util.Objects; + +/** + * Destination that represents an ingestion to an external source. + */ +@JsonTypeName(ExportDestination.TYPE_KEY) +public class ExportDestination implements IngestDestination +{ + public static final String TYPE_KEY = "external"; + private final String destinationType; + private final Map<String, String> properties; + + public ExportDestination(@JsonProperty("destinationType") String destinationType, @JsonProperty("properties") Map<String, String> properties) + { + this.destinationType = destinationType; + this.properties = properties; + } + + @JsonProperty("destinationType") + public String getDestinationType() + { + return destinationType; + } + + @JsonProperty("properties") + public Map<String, String> getProperties() Review Comment: Changed to deserialize this instead via the objectMapper, which simplified the code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
