This is an automated email from the ASF dual-hosted git repository.
abhishek pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git
The following commit(s) were added to refs/heads/master by this push:
new 2a250a4e6e9 Fix GHA logs dir and make tar and upload conditional on
web console test failures (#15810)
2a250a4e6e9 is described below
commit 2a250a4e6e9844bb7a05225959f8f6ac96a522e0
Author: Vishesh Garg <[email protected]>
AuthorDate: Wed Jan 31 15:39:56 2024 +0530
Fix GHA logs dir and make tar and upload conditional on web console test
failures (#15810)
The PR makes 2 change:
Correct the current logs directory tarred in GHA static checks to log
Make the steps of logs tar-ing and uploading conditional on web console
test failures, which currently happens on any step failure in static checks
workflow
Sample logs before this change for failed static checks:
https://github.com/apache/druid/actions/runs/7719743853/job/21043502498
---
.github/workflows/static-checks.yml | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/.github/workflows/static-checks.yml
b/.github/workflows/static-checks.yml
index 3ccad9e8a50..100c6ee626a 100644
--- a/.github/workflows/static-checks.yml
+++ b/.github/workflows/static-checks.yml
@@ -178,6 +178,7 @@ jobs:
{ for i in 1 2 3; do npm run codecov && break || sleep 15; done }
- name: web console end-to-end test
+ id: web-console-test
run: |
./.github/scripts/setup_generate_license.sh
web-console/script/druid build
@@ -186,11 +187,11 @@ jobs:
web-console/script/druid stop
- name: Tar druid logs
- if: ${{ failure() }}
- run: tar cvzf ./druid-logs.tgz -C
./distribution/target/apache-druid-*-SNAPSHOT/ logs
+ if: ${{ steps.web-console-test.conclusion == 'failure' }}
+ run: tar cvzf ./druid-logs.tgz -C
./distribution/target/apache-druid-*-SNAPSHOT/ log
- name: Upload druid logs to GitHub
- if: ${{ failure() }}
+ if: ${{ steps.web-console-test.conclusion == 'failure' }}
uses: actions/upload-artifact@master
with:
name: Druid logs web-checks
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
