clintropolis commented on code in PR #15588:
URL: https://github.com/apache/druid/pull/15588#discussion_r1472609572
##########
web-console/src/druid-models/dimension-spec/dimension-spec.ts:
##########
@@ -35,9 +35,20 @@ export interface DimensionSpec {
readonly name: string;
readonly createBitmapIndex?: boolean;
readonly multiValueHandling?: string;
+ readonly castToType?: string;
}
-const KNOWN_TYPES = ['string', 'long', 'float', 'double', 'json'];
+// This is a web console internal made up column type that represents a multi
value dimension
+const MADE_UP_MV_COLUMN_TYPE = 'mv-string';
+function madeMadeUpMvDimensionSpec(name: string): DimensionSpec {
Review Comment:
nit: should this be `makeMadeUpMvDimensionSpec`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
