georgew5656 opened a new pull request, #15820: URL: https://github.com/apache/druid/pull/15820
Switching druid web-console to suggest using the azureStorage input type instead of the azure input type due to changes from https://github.com/apache/druid/commit/3e512249e37407c0ece2b241d4b16e448eb18f0a ### Description The azureStorage input type is more full featured for azure ingestion than the azure input type so the console should suggest using it instead. imo using a sas token for authentication is the best solution (outside of using managed auth) because sas tokens can be short lived. #### Fixed the bug ... #### Renamed the class ... #### Added a forbidden-apis entry ... - Updated azure ingestion tiles to use the azureStorage input source - allow specifying a static sas token through the console. #### Release note - Updates to the web-console to use new input spec for azure ##### Key changed/added classes in this PR * `external-config.ts` * `ingestion-spec.tsx` * `load-data-view.tsx` <hr> <!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist below are strictly necessary, but it would be very helpful if you at least self-review the PR. --> This PR has: - [ X been self-reviewed. - [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.) - [ ] added documentation for new or modified features or behaviors. - [ ] a release note entry in the PR description. - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md) - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [X] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [ ] added integration tests. - [X] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
