lkm commented on code in PR #15819:
URL: https://github.com/apache/druid/pull/15819#discussion_r1475854162
##########
extensions-core/kubernetes-extensions/src/main/java/org/apache/druid/k8s/discovery/DefaultK8sApiClient.java:
##########
@@ -131,7 +131,7 @@ public boolean hasNext() throws SocketTimeoutException
try {
while (watch.hasNext()) {
Watch.Response<V1Pod> item = watch.next();
- if (item != null && item.type != null) {
+ if (item != null && item.type != null &&
!item.type.equals(WatchResult.BOOKMARK)) {
Review Comment:
We're actually not totally ignoring the result, we are updating the
resourceVersion which helps to reduce load on Kubernetes API so it does make
sense to get those. See for details
https://kubernetes.io/docs/reference/using-api/api-concepts/#watch-bookmarks
https://github.com/apache/druid/blob/2e46a980245bc1f2694dd21af9425855e78632f9/extensions-core/kubernetes-extensions/src/main/java/org/apache/druid/k8s/discovery/K8sDruidNodeDiscoveryProvider.java#L282
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
