xvrl commented on code in PR #15772:
URL: https://github.com/apache/druid/pull/15772#discussion_r1476301395
##########
extensions-core/orc-extensions/src/test/java/org/apache/druid/data/input/orc/OrcReaderTest.java:
##########
@@ -314,8 +314,8 @@ public void testJsonPathFunctions() throws IOException
//deviation of [7,8,9] is 1/3, stddev is sqrt(1/3), approximately
0.8165
Assert.assertEquals(0.8165,
Double.parseDouble(Iterables.getOnlyElement(row.getDimension("stddev"))),
0.0001);
- //append is not supported
- Assert.assertEquals(Collections.emptyList(),
row.getDimension("append"));
+ //Support for append has been added in json-path-2.9.0
+ //Assert.assertEquals(Collections.emptyList(),
row.getDimension("append"));
Review Comment:
understood, but there are two issues here:
1. as a principle we don't leave commented code unless there's a very good
reason.
2. This is potentially being breaking change. Any json-path expression using
append today would have silently been ignored, but would now cause an error.
My suggestion would be to:
1. update the test to check that we do get the exception
2. make a note in the PR description that we should call this out in the
release notes as a potential issue to watch out for when upgrading.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
