pranavbhole opened a new pull request, #15881:
URL: https://github.com/apache/druid/pull/15881
**Background:**
Geo spatial column in druid at present stores coordinate as CSV string in
string column and does RTree based indexing while ingestion. RTree based index
are created based on the Float values of coordinates and not double, this
conversion basically looses the accuracy of up 111 meters in geo distance.
For querying, druid support geo filters like Rectangle, Radius and Polygon
with float precision, thus if user enters double precision coordinate then it
looses the actual precision by at max 111 meters.
**What are the remediation steps?**
We can not change the RTree indexing data type from float to double, it will
not be backward compatible change. But we can very much prevent the precious
loss at the Spatial filter level and at least compare with accurate coordinates
with underline float RTree indexing. This will improve the accuracy but wont
fix it 100 %.
We are working on one more Improvement Proposal for implementing Geo Complex
column double precision and this PR is mandatory for that change anyways.
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
