gianm commented on code in PR #15622:
URL: https://github.com/apache/druid/pull/15622#discussion_r1485666716
##########
processing/src/main/java/org/apache/druid/query/expression/NestedDataExpressions.java:
##########
@@ -818,14 +702,6 @@ public ExprEval eval(ObjectBinding bindings)
);
}
-
- @Override
- public Expr visit(Shuttle shuttle)
- {
- List<Expr> newArgs = args.stream().map(x ->
x.visit(shuttle)).collect(Collectors.toList());
- return shuttle.visit(new JsonKeysExpr(newArgs));
- }
-
@Nullable
Review Comment:
I removed the `@Nullable` and left it without any annotation.
I don't think we have an official project style on this, so different people
do different things, but I personally prefer to leave nonnullable things
without any annotation. Most methods are not nullable and I feel like omitting
the `@NotNull` annotation keeps the code cleaner. If it's important for a
certain package, we could use `@EverythingIsNonnullByDefault` in
`package-info.java`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
