github-advanced-security[bot] commented on code in PR #15724:
URL: https://github.com/apache/druid/pull/15724#discussion_r1502006220
##########
indexing-service/src/test/java/org/apache/druid/indexing/overlord/http/OverlordResourceTest.java:
##########
@@ -1794,6 +1794,82 @@
Assert.assertEquals(expectedResourceActions, resourceActions);
}
+ @Test
+ public void testGetMultipleTaskStatuses_presentTaskQueue()
+ {
+ // Needed for teardown
+ EasyMock.replay(
+ authConfig,
+ taskRunner,
+ taskMaster,
+ taskStorageQueryAdapter,
+ indexerMetadataStorageAdapter,
+ req,
+ workerTaskRunnerQueryAdapter
+ );
+
+ TaskQueue taskQueue = EasyMock.createMock(TaskQueue.class);
+ EasyMock.expect(taskQueue.getTaskStatus("task"))
+ .andReturn(Optional.of(TaskStatus.running("task")));
+ EasyMock.replay(taskQueue);
+ TaskMaster taskMaster = EasyMock.createMock(TaskMaster.class);
Review Comment:
## Possible confusion of local and field
Confusing name: method [testGetMultipleTaskStatuses_presentTaskQueue](1)
also refers to field [taskMaster](2) (without qualifying it with 'this').
[Show more
details](https://github.com/apache/druid/security/code-scanning/6772)
##########
indexing-service/src/test/java/org/apache/druid/indexing/overlord/http/OverlordResourceTest.java:
##########
@@ -1794,6 +1794,82 @@
Assert.assertEquals(expectedResourceActions, resourceActions);
}
+ @Test
+ public void testGetMultipleTaskStatuses_presentTaskQueue()
+ {
+ // Needed for teardown
+ EasyMock.replay(
+ authConfig,
+ taskRunner,
+ taskMaster,
+ taskStorageQueryAdapter,
+ indexerMetadataStorageAdapter,
+ req,
+ workerTaskRunnerQueryAdapter
+ );
+
+ TaskQueue taskQueue = EasyMock.createMock(TaskQueue.class);
+ EasyMock.expect(taskQueue.getTaskStatus("task"))
+ .andReturn(Optional.of(TaskStatus.running("task")));
+ EasyMock.replay(taskQueue);
+ TaskMaster taskMaster = EasyMock.createMock(TaskMaster.class);
+
EasyMock.expect(taskMaster.getTaskQueue()).andReturn(Optional.of(taskQueue));
+ EasyMock.replay(taskMaster);
+ OverlordResource overlordResource = new OverlordResource(
+ taskMaster,
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ null
+ );
+ final Object response =
overlordResource.getMultipleTaskStatuses(ImmutableSet.of("task"))
+ .getEntity();
+ Assert.assertEquals(ImmutableMap.of("task", TaskStatus.running("task")),
response);
+ }
+
+ @Test
+ public void testGetMultipleTaskStatuses_absentTaskQueue()
+ {
+ // Needed for teardown
+ EasyMock.replay(
+ authConfig,
+ taskRunner,
+ taskMaster,
+ taskStorageQueryAdapter,
+ indexerMetadataStorageAdapter,
+ req,
+ workerTaskRunnerQueryAdapter
+ );
+
+ TaskStorageQueryAdapter taskStorageQueryAdapter =
EasyMock.createMock(TaskStorageQueryAdapter.class);
+ EasyMock.expect(taskStorageQueryAdapter.getStatus("task"))
+ .andReturn(Optional.of(TaskStatus.running("task")));
+ EasyMock.replay(taskStorageQueryAdapter);
+ TaskMaster taskMaster = EasyMock.createMock(TaskMaster.class);
Review Comment:
## Possible confusion of local and field
Confusing name: method [testGetMultipleTaskStatuses_absentTaskQueue](1) also
refers to field [taskMaster](2) (without qualifying it with 'this').
[Show more
details](https://github.com/apache/druid/security/code-scanning/6774)
##########
indexing-service/src/test/java/org/apache/druid/indexing/overlord/http/OverlordResourceTest.java:
##########
@@ -1794,6 +1794,82 @@
Assert.assertEquals(expectedResourceActions, resourceActions);
}
+ @Test
+ public void testGetMultipleTaskStatuses_presentTaskQueue()
+ {
+ // Needed for teardown
+ EasyMock.replay(
+ authConfig,
+ taskRunner,
+ taskMaster,
+ taskStorageQueryAdapter,
+ indexerMetadataStorageAdapter,
+ req,
+ workerTaskRunnerQueryAdapter
+ );
+
+ TaskQueue taskQueue = EasyMock.createMock(TaskQueue.class);
+ EasyMock.expect(taskQueue.getTaskStatus("task"))
+ .andReturn(Optional.of(TaskStatus.running("task")));
+ EasyMock.replay(taskQueue);
+ TaskMaster taskMaster = EasyMock.createMock(TaskMaster.class);
+
EasyMock.expect(taskMaster.getTaskQueue()).andReturn(Optional.of(taskQueue));
+ EasyMock.replay(taskMaster);
+ OverlordResource overlordResource = new OverlordResource(
+ taskMaster,
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ null
+ );
+ final Object response =
overlordResource.getMultipleTaskStatuses(ImmutableSet.of("task"))
+ .getEntity();
+ Assert.assertEquals(ImmutableMap.of("task", TaskStatus.running("task")),
response);
+ }
+
+ @Test
+ public void testGetMultipleTaskStatuses_absentTaskQueue()
+ {
+ // Needed for teardown
+ EasyMock.replay(
+ authConfig,
+ taskRunner,
+ taskMaster,
+ taskStorageQueryAdapter,
+ indexerMetadataStorageAdapter,
+ req,
+ workerTaskRunnerQueryAdapter
+ );
+
+ TaskStorageQueryAdapter taskStorageQueryAdapter =
EasyMock.createMock(TaskStorageQueryAdapter.class);
Review Comment:
## Possible confusion of local and field
Confusing name: method [testGetMultipleTaskStatuses_absentTaskQueue](1) also
refers to field [taskStorageQueryAdapter](2) (without qualifying it with
'this').
[Show more
details](https://github.com/apache/druid/security/code-scanning/6773)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
