zachjsh commented on code in PR #15961:
URL: https://github.com/apache/druid/pull/15961#discussion_r1503157783
##########
sql/src/test/java/org/apache/druid/sql/calcite/CalciteInsertDmlTest.java:
##########
@@ -657,6 +659,52 @@ public void testPartitionedBySupportedClauses()
didTest = true;
}
+ @Test
+ public void testPartitionedBySupportedGranularityLiteralClauses()
+ {
+ final RowSignature targetRowSignature = RowSignature.builder()
+ .add("__time",
ColumnType.LONG)
+ .add("dim1",
ColumnType.STRING)
+ .build();
+
+ final Map<String, Granularity> partitionedByToGranularity =
+ Arrays.stream(GranularityType.values())
+ .collect(Collectors.toMap(GranularityType::name,
GranularityType::getDefaultGranularity));
+
+ final ObjectMapper queryJsonMapper = queryFramework().queryJsonMapper();
+ partitionedByToGranularity.forEach((partitionedByArgument,
expectedGranularity) -> {
+ Map<String, Object> queryContext = null;
+ try {
+ queryContext = ImmutableMap.of(
+ DruidSqlInsert.SQL_INSERT_SEGMENT_GRANULARITY,
queryJsonMapper.writeValueAsString(expectedGranularity)
+ );
+ }
+ catch (JsonProcessingException e) {
+ // Won't reach here
+ Assert.fail(e.getMessage());
+ }
+
+ testIngestionQuery()
+ .sql(StringUtils.format(
+ "INSERT INTO druid.dst SELECT __time, dim1 FROM foo PARTITIONED
BY '%s'",
+ partitionedByArgument
+ ))
+ .expectTarget("dst", targetRowSignature)
+ .expectResources(dataSourceRead("foo"), dataSourceWrite("dst"))
+ .expectQuery(
Review Comment:
should we test the expected granularity here too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
