somu-imply commented on code in PR #15916:
URL: https://github.com/apache/druid/pull/15916#discussion_r1503296413
##########
sql/src/main/java/org/apache/druid/sql/calcite/expression/builtin/IPv4AddressMatchOperatorConversion.java:
##########
@@ -49,7 +49,7 @@ public class IPv4AddressMatchOperatorConversion extends
DirectOperatorConversion
SUBNET_OPERAND
)
)
- .returnTypeInference(ReturnTypes.BOOLEAN_NULLABLE)
+ .returnTypeNullable(SqlTypeName.BOOLEAN)
Review Comment:
This does not need to be changed as ipv4 even if 2nd arg is null throws a
validation exception and does not return null in anyway. So I think it can be
left out
##########
sql/src/main/java/org/apache/druid/sql/calcite/expression/builtin/IPv4AddressMatchOperatorConversion.java:
##########
@@ -49,7 +49,7 @@ public class IPv4AddressMatchOperatorConversion extends
DirectOperatorConversion
SUBNET_OPERAND
)
)
- .returnTypeInference(ReturnTypes.BOOLEAN_NULLABLE)
+ .returnTypeNullable(SqlTypeName.BOOLEAN)
Review Comment:
This does not need to be changed as ipv4_match even if 2nd arg is null
throws a validation exception and does not return null in anyway. So I think it
can be left out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
