github-advanced-security[bot] commented on code in PR #15976:
URL: https://github.com/apache/druid/pull/15976#discussion_r1503729834
##########
extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/KubernetesTaskRunner.java:
##########
@@ -471,4 +525,44 @@
{
return tasks.size();
}
+
+ private boolean isTaskEligibleToRun(Task task)
+ {
+ TaskLane taskLane = taskLaneRegistry.getTaskLane(task.getLabel());
+ if (taskLane == null || (taskLane != null && taskLane.getPolicy() ==
TaskLaneCapacityPolicy.RESERVE)) {
Review Comment:
## Useless null check
This check is useless. [taskLane](1) cannot be null at this check, since it
is guarded by [... == ...](2).
[Show more
details](https://github.com/apache/druid/security/code-scanning/6778)
##########
extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/KubernetesTaskRunner.java:
##########
@@ -145,23 +157,46 @@
@Override
public ListenableFuture<TaskStatus> run(Task task)
{
- synchronized (tasks) {
- return tasks.computeIfAbsent(task.getId(), k -> new
KubernetesWorkItem(task, exec.submit(() -> runTask(task))))
- .getResult();
- }
+ return runTask(task, false);
+ }
+
+ private void queueTask(Task task)
+ {
+ Queue<Runnable> queue = taskLaneQueues.get(task.getLabel());
+ queue.offer(() -> runTask(task, true));
}
protected ListenableFuture<TaskStatus> joinAsync(Task task)
{
synchronized (tasks) {
- return tasks.computeIfAbsent(task.getId(), k -> new
KubernetesWorkItem(task, exec.submit(() -> joinTask(task))))
- .getResult();
+ return tasks.computeIfAbsent(task.getId(), k -> {
+ ListenableFuture<TaskStatus> unused = exec.submit(() ->
joinTask(task));
Review Comment:
## Unread local variable
Variable 'ListenableFuture<TaskStatus> unused' is never read.
[Show more
details](https://github.com/apache/druid/security/code-scanning/5900)
##########
extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/KubernetesTaskRunner.java:
##########
@@ -145,23 +157,46 @@
@Override
public ListenableFuture<TaskStatus> run(Task task)
{
- synchronized (tasks) {
- return tasks.computeIfAbsent(task.getId(), k -> new
KubernetesWorkItem(task, exec.submit(() -> runTask(task))))
- .getResult();
- }
+ return runTask(task, false);
+ }
+
+ private void queueTask(Task task)
+ {
+ Queue<Runnable> queue = taskLaneQueues.get(task.getLabel());
+ queue.offer(() -> runTask(task, true));
Review Comment:
## Ignored error status of call
Method queueTask ignores exceptional return value of Queue<Runnable>.offer.
[Show more
details](https://github.com/apache/druid/security/code-scanning/6779)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
