YongGang commented on code in PR #15947:
URL: https://github.com/apache/druid/pull/15947#discussion_r1504888115
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/IngestionStatsAndErrorsTaskReportData.java:
##########
@@ -57,7 +62,9 @@ public IngestionStatsAndErrorsTaskReportData(
@JsonProperty("errorMsg") @Nullable String errorMsg,
@JsonProperty("segmentAvailabilityConfirmed") boolean
segmentAvailabilityConfirmed,
@JsonProperty("segmentAvailabilityWaitTimeMs") long
segmentAvailabilityWaitTimeMs,
- @JsonProperty("recordsProcessed") Map<String, Long> recordsProcessed
+ @JsonProperty("recordsProcessed") Map<String, Long> recordsProcessed,
+ @JsonProperty("segmentsRead") int segmentsRead,
Review Comment:
I think the data type for these two new fields should be `Long` (can be
nullable). For tasks that don't read or publish segments these will be null
value, if using 0 then hard to distinguish if task is really reading 0 segments
(maybe due to some task failure) or this field is not applicable for the task
type.
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/GeneratedPartitionsMetadataReport.java:
##########
@@ -38,9 +38,10 @@ class GeneratedPartitionsMetadataReport extends
GeneratedPartitionsReport
GeneratedPartitionsMetadataReport(
@JsonProperty("taskId") String taskId,
@JsonProperty("partitionStats") List<PartitionStat> partitionStats,
- @JsonProperty("taskReport") Map<String, TaskReport> taskReport
+ @JsonProperty("taskReport") Map<String, TaskReport> taskReport,
+ @JsonProperty("segmentsRead") Integer segmentsRead
Review Comment:
`Long` type is more future proof and align with other numeric metric
recorded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
