gzhao9 commented on PR #15187: URL: https://github.com/apache/druid/pull/15187#issuecomment-1969976757
> Thanks for trying to improve the tests, @gzhao9 ! > > `DataSegment` is a simple POJO Druid class which should not be mocked. Any test doing this should instead be updated to use concrete `DataSegment` objects. You can either use a `DataSegment.Builder` or the `CreateDataSegment` utility to easily create `DataSegment` objects in test. > > Also, this is a change that doesn't affect Druid users in any way, so it doesn't need a release note. Hi, sorry for the delayed response. I have removed the changes regarding the `DataSegment` section. Because this PR is mainly trying to reduce mock cloning in tests. In the meantime, I submitted another PR that also tries to reduce mock cloning in tests. See the detail in #15980 If you are interested please take a look as well. @kfaraz @cryptoe -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
