gianm commented on PR #16004: URL: https://github.com/apache/druid/pull/16004#issuecomment-1971730410
We did release #15689 in 29.0.0. It accidentally included a breaking API change, which is problematic. This PR reverts the breaking change, but since #15689 has already been released, that means this PR is _also_ a breaking API change. We need to treat it as such. There's a few options: 1. Don't make this change, just accept that #15689 had an unintentional breaking change, and keep rolling with the new format. 2. Make this change, and document in the release notes that 29.0.0 had a different format for `targetDataSource` from both prior and future versions. 3. Provide a migration path: add a query context property that controls the format of `targetDataSource` and allow people to override it. IMO, given that this API is not likely widely used, and 29.0.0 was just a single release, (2) is the best option. But we do need to consider the other options when reviewing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
