georgew5656 commented on code in PR #16016: URL: https://github.com/apache/druid/pull/16016#discussion_r1508261001
########## docs/development/extensions-core/azure.md: ########## @@ -42,6 +42,6 @@ To use this Apache Druid extension, [include](../../configuration/extensions.md# |`druid.azure.protocol`|the protocol to use|http or https|https| |`druid.azure.maxTries`|Number of tries before canceling an Azure operation.| |3| |`druid.azure.maxListingLength`|maximum number of input files matching a given prefix to retrieve at a time| |1024| -|`druid.azure.endpointSuffix`|The endpoint suffix to use. Override the default value to connect to [Azure Government](https://learn.microsoft.com/en-us/azure/azure-government/documentation-government-get-started-connect-to-storage#getting-started-with-storage-api).|Examples: `core.windows.net`, `core.usgovcloudapi.net`|`core.windows.net`| - +|`druid.azure.endpointSuffix`| The endpoint suffix to use. Override the default value to connect to [Azure Government](https://learn.microsoft.com/en-us/azure/azure-government/documentation-government-get-started-connect-to-storage#getting-started-with-storage-api). This config will be deprecated in a future release in favor of `druid.azure.storageAccountEndpointSuffix`. | Examples: `core.windows.net`, `core.usgovcloudapi.net` | Optional | Review Comment: i would probably just remove this line from the docs if the property is deprecated ########## docs/development/extensions-core/azure.md: ########## @@ -42,6 +42,6 @@ To use this Apache Druid extension, [include](../../configuration/extensions.md# |`druid.azure.protocol`|the protocol to use|http or https|https| |`druid.azure.maxTries`|Number of tries before canceling an Azure operation.| |3| |`druid.azure.maxListingLength`|maximum number of input files matching a given prefix to retrieve at a time| |1024| -|`druid.azure.endpointSuffix`|The endpoint suffix to use. Override the default value to connect to [Azure Government](https://learn.microsoft.com/en-us/azure/azure-government/documentation-government-get-started-connect-to-storage#getting-started-with-storage-api).|Examples: `core.windows.net`, `core.usgovcloudapi.net`|`core.windows.net`| - +|`druid.azure.endpointSuffix`| The endpoint suffix to use. Override the default value to connect to [Azure Government](https://learn.microsoft.com/en-us/azure/azure-government/documentation-government-get-started-connect-to-storage#getting-started-with-storage-api). This config will be deprecated in a future release in favor of `druid.azure.storageAccountEndpointSuffix`. | Examples: `core.windows.net`, `core.usgovcloudapi.net` | Optional | Review Comment: can you keep the current whitespace for these changes? hard to tell whats going on ########## extensions-core/azure-extensions/src/main/java/org/apache/druid/storage/azure/AzureAccountConfig.java: ########## @@ -124,18 +140,76 @@ public void setSharedAccessStorageToken(String sharedAccessStorageToken) this.sharedAccessStorageToken = sharedAccessStorageToken; } + @SuppressWarnings("unused") // Used by Jackson deserialization? + public void setManagedIdentityClientId(String managedIdentityClientId) + { + this.managedIdentityClientId = managedIdentityClientId; + } + public void setUseAzureCredentialsChain(Boolean useAzureCredentialsChain) { this.useAzureCredentialsChain = useAzureCredentialsChain; } + @Nullable + @Deprecated public String getEndpointSuffix() { return endpointSuffix; } + public String getStorageAccountEndpointSuffix() + { + return storageAccountEndpointSuffix; + } + public String getBlobStorageEndpoint() { - return "blob." + endpointSuffix; + if (endpointSuffix != null) { Review Comment: can you add a comment here explaining this is here to support the legacy runtime property? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
