github-advanced-security[bot] commented on code in PR #15976:
URL: https://github.com/apache/druid/pull/15976#discussion_r1511953905
##########
extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/KubernetesTaskRunner.java:
##########
@@ -144,24 +160,48 @@
@Override
public ListenableFuture<TaskStatus> run(Task task)
+ {
+ return runTask(task, false);
+ }
+
+ protected ListenableFuture<TaskStatus> joinAsync(Task task)
{
synchronized (tasks) {
- return tasks.computeIfAbsent(task.getId(), k -> new
KubernetesWorkItem(task, exec.submit(() -> runTask(task))))
- .getResult();
+ return tasks.computeIfAbsent(task.getId(), k -> {
+ ListenableFuture<TaskStatus> unused = exec.submit(() ->
joinTask(task));
+ return new KubernetesWorkItem(task);
+ }).getResult();
}
}
- protected ListenableFuture<TaskStatus> joinAsync(Task task)
+ private ListenableFuture<TaskStatus> runTask(Task task, boolean isQueued)
{
synchronized (tasks) {
- return tasks.computeIfAbsent(task.getId(), k -> new
KubernetesWorkItem(task, exec.submit(() -> joinTask(task))))
- .getResult();
+ KubernetesWorkItem workItem = tasks.get(task.getId());
+ // Return existing task result if already submitted and not queued
+ if (workItem != null && !isQueued) {
+ return workItem.getResult();
+ }
+
+ if (workItem == null) {
+ workItem = new KubernetesWorkItem(task);
+ tasks.put(task.getId(), workItem);
+ }
+
+ if (isTaskEligibleToRun(task)) {
+ ListenableFuture<TaskStatus> unused = exec.submit(() -> doTask(task,
true));
Review Comment:
## Unread local variable
Variable 'ListenableFuture<TaskStatus> unused' is never read.
[Show more
details](https://github.com/apache/druid/security/code-scanning/6973)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
