cryptoe commented on code in PR #16034: URL: https://github.com/apache/druid/pull/16034#discussion_r1512181804
########## extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/input/table/SegmentsInputSliceTest.java: ########## @@ -78,6 +78,31 @@ public void testSerde() throws Exception ); } + @Test + public void testSerde2() throws Exception + { + final ObjectMapper mapper = TestHelper.makeJsonMapper() + .registerModules(new MSQIndexingModule().getJacksonModules()); + + final SegmentsInputSlice slice = new SegmentsInputSlice( + "myds", + ImmutableList.of( + new RichSegmentDescriptor( + Intervals.of("2000/P1M"), + Intervals.of("2000/P1M"), + "1", + 0 + ) + ), + null + ); + + Assert.assertEquals( + slice, + mapper.readValue(mapper.writeValueAsString(slice), InputSlice.class) Review Comment: We would want to have a handCreated pojo without the key ` @JsonProperty("servedSegments"` rite ? because that would be sent over the write from the old controller. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org