kfaraz commented on code in PR #15947: URL: https://github.com/apache/druid/pull/15947#discussion_r1512581388
########## indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/GeneratedPartitionsReport.java: ########## @@ -37,11 +38,19 @@ public class GeneratedPartitionsReport implements SubTaskReport private final List<PartitionStat> partitionStats; private final Map<String, TaskReport> taskReport; - GeneratedPartitionsReport(String taskId, List<PartitionStat> partitionStats, Map<String, TaskReport> taskReport) + private final Long segmentsRead; + + GeneratedPartitionsReport( + String taskId, + List<PartitionStat> partitionStats, + Map<String, TaskReport> taskReport, + Long segmentsRead Review Comment: It is weird to have `segmentsRead` as a top-level field in all of these classes when we already have the `TaskReport` objects that are being passed here. Ideally, this field should be present inside the `taskReport` map passed to this class (inside the corresponding `IngestionStatsAndErrorReportData` object and then later be extracted and processed in `ParallelIndexSupervisorTask` as needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
