kfaraz commented on code in PR #15930: URL: https://github.com/apache/druid/pull/15930#discussion_r1512999440
########## indexing-service/src/main/java/org/apache/druid/indexing/common/IngestionStatsAndErrorsTaskReportData.java: ########## @@ -101,6 +106,13 @@ public long getSegmentAvailabilityWaitTimeMs() return segmentAvailabilityWaitTimeMs; } + @JsonProperty + @Nullable + public Map<String, Long> getRecordsProcessed() Review Comment: @adithyachakilam , just noticed this. This field is marked nullable for serialization. It should be marked nullable in the constructor too. Otherwise, we will not be able to deserialize older reports which do not have the field `recordsProcessed`. Please also add a test to verify this. You may include these changes in #16402. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org